-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Konflux imported: Get RPMs from build instead of from a (sub)task(s) #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpopelka
force-pushed
the
cg_import
branch
3 times, most recently
from
December 17, 2024 15:45
83f75a4
to
d98e173
Compare
jpopelka
added a commit
to jpopelka/installability-pipeline
that referenced
this pull request
Dec 17, 2024
msrb
reviewed
Dec 18, 2024
msrb
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The codebase of this project is a total shell hell... I trust Jirka that he tested his changes -- lgtm ;) 👍
@jpopelka Feel free to merge. Could you please also build a new RPM in https://copr.fedorainfracloud.org/coprs/g/osci/mini-tps/ ? |
it failed with 'No such entry in table tag:'
it failed with 'invalid format'
and indent the XMLs
Even we truncate them, it's too much info and we have them in the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/OSCI-7904