Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend: remember the username and prefill it the next time #107

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

FrostyX
Copy link
Member

@FrostyX FrostyX commented Feb 16, 2024

Fix #101

We are storing the value into localStorage instead cookies, so that nothing is on the server and we don't have to show the annoying "accept cookies" dialog.

https://www.w3schools.com/jsref/prop_win_localstorage.asp

Fix fedora-copr#101

We are storing the value into `localStorage` instead cookies, so that
nothing is on the server and we don't have to show the annoying
"accept cookies" dialog.

https://www.w3schools.com/jsref/prop_win_localstorage.asp
Copy link
Member

@praiskup praiskup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@praiskup
Copy link
Member

I can confirm it works in firefox-122.0.1-1.fc39.x86_64

@FrostyX FrostyX merged commit 8bf66ab into fedora-copr:main Feb 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The username should be saved in cookies
2 participants