-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review page feature #140
Review page feature #140
Conversation
6e32add
to
378d157
Compare
if os.environ.get("ENV") == "production": | ||
raise NotImplementedError("Reviewing is not ready yet") | ||
|
||
def frontend_review_random(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no type?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The response structure is checked at the return statement with feedback schema - there's just added id
for the reference and I didn't want to add another unicorn schema to schema.py
since this will disappear with database creation and simply the structure is parsed - just the id
is added at the end.
@nikromen I see you rebased. Were there any manual merge conflicts or everything went fine? |
@FrostyX there were 2 big merge conflicts with needs of manual resolving - since a lot o fit was on frontend I created another branch for this PR if I screwed since I don't know much about the FE part. But it seems like it's working fine |
0649636
to
36c16bd
Compare
I checked it out locally (36c16bd) and sadly when I click on 'review logs' I get 405:
|
81e31dc
to
7775f87
Compare
We've worked with @nikromen on how to run this locally. Turned out I hate to wipe evrything in |
Once I submit a review, it's great that I get a message saying
And a link to submit "Another log" which redirects me to |
# TODO: temporary silly solution until database is created | ||
# (missing provider but we can dig it from original feedback file) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was confused about that directory structure, now I understand :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for addressing my comments. Works well for me now!
This should be more or less the final look of the review page.
Fixes: #4