Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: copy initial code to frontend container and set workdir #32

Merged
merged 2 commits into from
Dec 4, 2023

Conversation

FrostyX
Copy link
Member

@FrostyX FrostyX commented Nov 27, 2023

Otherwise, we are basically running the npm install in root directory. See https://stackoverflow.com/a/65443098/3285282

Copy link
Collaborator

@TomasTomecek TomasTomecek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...and I was curious how the source code gets into the container :)

build works for me now just fine

@jpodivin
Copy link
Collaborator

Build is failing for me with:

log-detective-website-frontend-1  | [:app] Configuring build.
log-detective-website-frontend-1  | [:app] Compiling ...
log-detective-website-frontend-1  | [:app] Build failure:
log-detective-website-frontend-1  | The required namespace "react" is not available, it was required by "reagent/core.cljs".

The app doesn't seem to be running either, is it just me?

@TomasTomecek
Copy link
Collaborator

Interesting, I got the same actually:

frontend_1  | shadow-cljs - dependencies updated
frontend_1  | shadow-cljs - HTTP server available at http://localhost:3000
frontend_1  | shadow-cljs - server version: 2.26.2 running at http://localhost:9630
frontend_1  | shadow-cljs - nREPL server started on port 3333
frontend_1  | shadow-cljs - watching build :app
frontend_1  | [:app] Configuring build.
frontend_1  | [:app] Compiling ...
frontend_1  | [:app] Build failure:
frontend_1  | The required namespace "react" is not available, it was required by "reagent/core.cljs".
frontend_1  |

The frontend was served but without assets.

@FrostyX
Copy link
Member Author

FrostyX commented Nov 28, 2023

@jpodivin can you please try docker-compose build frontend --no-cache?

@FrostyX
Copy link
Member Author

FrostyX commented Dec 4, 2023

I am merging, this is IMHO a step in the right direction. We can iterate on the @jpodivin issue in a follow-up.

@FrostyX FrostyX merged commit e82056e into fedora-copr:main Dec 4, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants