Statistics display #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpodivin
force-pushed
the
stats
branch
3 times, most recently
from
c444326 to
897b3f4
Compare
TomasTomecek
approved these changes
Jan 22, 2024
nikromen
reviewed
Jan 22, 2024
|
I'd propose 500 to make it realistic (100 is going to exist by the end of January). |
FrostyX
reviewed
Jan 23, 2024
jpodivin
force-pushed
the
stats
branch
2 times, most recently
from
e494054 to
a4bf8f8
Compare
FrostyX
reviewed
Jan 23, 2024
frontend/src/app/homepage.cljs
Outdated
| (float | ||
| (/ | ||
| (:total_reports @backend-stats) | ||
| @report-target)) 100) 100)) |
There was a problem hiding this comment.
We will probably need to round the number. In my case backend returns a reasonable number:
{"total_reports":7}but frontend prints
Are we there yet?
0.7000000000000001%
frontend/src/app/homepage.cljs
Outdated
| [:div { | ||
| :id "progress" | ||
| :style {:width (str (progress-width) "%")} | ||
| }]]) |
There was a problem hiding this comment.
I'll need to set up some linter for the formatting. In comparison to e.g. python, AFAIK all lisps do:
- Ending brackets are not on their own lines. All of them are at the end of the last command
- We don't write opening bracket and then newline. e.g.
:div {\n. The{goes to the same line as whatever comes after it
So for example:
(defn render-stats []
[:div {:id "progressbar"}
[:h5 "Are we there yet?"]
[:div {:id "progressbar-number"}
[:p (progress-width) "%"]]
[:div
{:id "progress"
:style {:width (str (progress-width) "%")}}]])Especially the ending brackets are incorrect on multiple places
jpodivin
force-pushed
the
stats
branch
2 times, most recently
from
7a5423b to
0c17e0c
Compare
Signed-off-by: Jiri Podivin <[email protected]>
Signed-off-by: Jiri Podivin <[email protected]>
FrostyX
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to decide on our report collection target before merging this. Something that is ambitious, yet reachable.
Until we know for sure we shouldn't merge it.