Improve camera flash #487
Merged
Improve camera flash #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improves the usage of the camera flash to make it more reliably be on when it is supposed to be. Addresses issue feelfreelinux#87
|
LGTM, thanks for fixing this up :) |
|
Will prepare a new release soonish |
|
Unfortunately I just ran a print with this and the light can still get stuck on. This is an improvement, but not a full fix yet. edit: Though it eventually unstuck and appears to be working well ... maybe it just took the phone a really long time to realize that the web browser disconnected? Or maybe there are still issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the usage of the camera flash to make it more reliably be on when it is supposed to be.
Closes issue #87