curve ERC4626 #11
Draft
curve ERC4626 #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eswak
reviewed
Mar 31, 2022
| contract CurveERC4626 is ERC4626, RewardsClaimer { | ||
| using SafeTransferLib for ERC20; | ||
|
|
||
| /// @notice The Convex Rewards contract (for claiming rewards) |
eswak
reviewed
Mar 31, 2022
| @param _asset The ERC20 compliant token the Vault should accept. | ||
| @param _name The name for the vault token. | ||
| @param _symbol The symbol for the vault token. | ||
| @param _gauge The Convex Rewards contract (for claiming rewards). |
There was a problem hiding this comment.
*the Curve gauge (for staking tokens & claiming rewards)
eswak
reviewed
Mar 31, 2022
| @param _name The name for the vault token. | ||
| @param _symbol The symbol for the vault token. | ||
| @param _gauge The Convex Rewards contract (for claiming rewards). | ||
| @param _rewardsDestination the address to send CRV and CVX. |
There was a problem hiding this comment.
not necessarily CRV and CVX, it can be BAL for Balancer gauges too. And CVX don't work with a gauge system, only Curve distributes CRV this way
|
You could probably rename it from Code looks good (just fix the comments). After I see some unit tests I'll be comfident to merge, the code is very similar to what we use in prod already for staking in gauges :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#9