Skip to content

Commit

Permalink
Add Ubuntu 24.04 to the test matrix (#117)
Browse files Browse the repository at this point in the history
* Add Ubuntu 24.04 to the test matrix

* Add verdict job to simplify branch protection config
  • Loading branch information
felipecrs authored Jul 4, 2024
1 parent c0a5b33 commit 6be1a51
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 4 deletions.
7 changes: 6 additions & 1 deletion .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
fail-fast: false
matrix:
variant: [devcontainer, wsl, gnome]
os: [ubuntu-20.04, ubuntu-22.04]
os: [ubuntu-20.04, ubuntu-22.04, ubuntu-24.04]
include:
- variant: devcontainer
os: alpine
Expand All @@ -23,3 +23,8 @@ jobs:
- uses: actions/checkout@v4
- run: |
scripts/test.sh --variant "${{ matrix.variant }}" --os "${{ matrix.os }}"
verdict:
needs: test
runs-on: ubuntu-latest
steps:
- run: echo "All tests passed!"
6 changes: 3 additions & 3 deletions scripts/test.sh
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#!/bin/bash

# ARG_OPTIONAL_REPEATED([variant],[v],[The variant of the test to run. Possible values: devcontainer, wsl, and gnome. Default: devcontainer.],[])
# ARG_OPTIONAL_REPEATED([os],[o],[The OS to run the tests against. The list of possible values can be found at https://mcr.microsoft.com/v2/devcontainers/base/tags/list. Examples: ubuntu-18.04, ubuntu-22.04, and alpine. Default: ubuntu-20.04.],[])
# ARG_OPTIONAL_REPEATED([os],[o],[The OS to run the tests against. The list of possible values can be found at https://mcr.microsoft.com/v2/devcontainers/base/tags/list. Examples: ubuntu-24.04, alpine. Default: ubuntu-24.04.],[])
# ARG_OPTIONAL_BOOLEAN([debug],[d],[Whether to enable debug logs or not],[off])
# ARG_OPTIONAL_SINGLE([pre-script],[],[The custom script to run before the installation],[])
# ARG_HELP([Tests the installation of the dotfiles in differents scenarios],[])
Expand Down Expand Up @@ -35,7 +35,7 @@ print_help() {
printf '%s\n' "Tests the installation of the dotfiles in differents scenarios"
printf 'Usage: %s [-v|--variant <arg>] [-o|--os <arg>] [-d|--(no-)debug] [--pre-script <arg>] [-h|--help]\n' "$0"
printf '\t%s\n' "-v, --variant: The variant of the test to run. Possible values: devcontainer, wsl, and gnome. Default: devcontainer. (empty by default)"
printf '\t%s\n' "-o, --os: The OS to run the tests against. The list of possible values can be found at https://mcr.microsoft.com/v2/devcontainers/base/tags/list. Examples: ubuntu-18.04, ubuntu-22.04, and alpine. Default: ubuntu-20.04. (empty by default)"
printf '\t%s\n' "-o, --os: The OS to run the tests against. The list of possible values can be found at https://mcr.microsoft.com/v2/devcontainers/base/tags/list. Examples: ubuntu-24.04, alpine. Default: ubuntu-24.04. (empty by default)"
printf '\t%s\n' "-d, --debug, --no-debug: Whether to enable debug logs or not (off by default)"
printf '\t%s\n' "--pre-script: The custom script to run before the installation (no default)"
printf '\t%s\n' "-h, --help: Prints help"
Expand Down Expand Up @@ -160,7 +160,7 @@ if ((${#variants[@]} == 0)); then
fi
oses=("${_arg_os[@]}")
if ((${#oses[@]} == 0)); then
oses=("ubuntu-20.04")
oses=("ubuntu-24.04")
fi

for variant in "${variants[@]}"; do
Expand Down

0 comments on commit 6be1a51

Please sign in to comment.