Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent focusing the output tab #454

Merged
merged 2 commits into from
Dec 26, 2019
Merged

fix: prevent focusing the output tab #454

merged 2 commits into from
Dec 26, 2019

Conversation

d0x2f
Copy link
Contributor

@d0x2f d0x2f commented Oct 21, 2019

Hi,

Just a quick one to prevent the extension from stealing focus to the output tab.

These issues seem relevant: #450 #144 #65

@ilyahoilik
Copy link

@felixfbecker

1 similar comment
@barnesheaton
Copy link

@felixfbecker

@ahinkle
Copy link

ahinkle commented Nov 21, 2019

@Jupadr
Copy link

Jupadr commented Nov 25, 2019

@felixfbecker

@zacscott
Copy link

zacscott commented Dec 3, 2019

@felixfbecker Please, please accept this. This is the single most annoying thing I have to deal with on a daily basis

@vielhuber
Copy link

Please release.

@elgandoz
Copy link

elgandoz commented Dec 6, 2019

Please indeed. Every time I need to reload the window (which is several time a day) the output tabs repeatedly shows up, shouting in your face every single php file parsed. Hiding the panel and/or the tab is pointless, the panel will display anyway.
The extension is awesome, but this bug is nerve-wracking.

@zacscott
Copy link

@felixfbecker

1 similar comment
@ilyahoilik
Copy link

@felixfbecker

@elgandoz
Copy link

I would recommend to compile the extension on your own from the d0x2f fork. It takes one minute and it does the job. From the root of the repo:

composer install
npm install -g vsce && npm install
npm run build
vsce package

You'll find php-intellisense-1.5.4.vsix. The version won't match unless you edit the manifest, but it doesn't matter. Install via VSIX, from the Extensions menu.

@bbceg
Copy link

bbceg commented Dec 20, 2019

I had a bit of a shocker trying to get @elgandoz suggestion to work on WSL (and then on Git Bash). I had to run the following on WSL (the key being the --unsafe-perm):

`composer install
sudo npm install -g vsce && sudo npm install --unsafe-perm
sudo run build
sudo vsce package'

I suspect the issue is related to how WSL handles permissions although that doesn't explain why Git Bash didn't work. Hopefully this helps someone all the same.

@felixfbecker felixfbecker merged commit 4898e75 into felixfbecker:master Dec 26, 2019
@felixfbecker
Copy link
Owner

🎉 This PR is included in version 2.3.14 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

jarstelfox added a commit to jarstelfox/psalm-vscode-plugin that referenced this pull request Jun 8, 2022
Just a quick one to prevent the extension from stealing focus to the output tab

See: felixfbecker/vscode-php-intellisense#454

Fixes: psalm#141
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants