-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
1100: Fix a python formatting issue raised by black r=Hoverbear a=Hoverbear Just a little whitespace! (See ferrocene/sphinx-shared-resources#46) 1103: let ci env vars propagate to setup-ubuntu.sh r=Hoverbear a=tshepang This fixes the issue where disk space was not freed. Should of been part of 3f84720. Co-authored-by: Ana Hobden <[email protected]> Co-authored-by: Tshepang Mbambo <[email protected]>
c70ce1a
to
5f32ef8
Compare
Just stating that these changes do not include changes still umerged in ferrocene/ferrocene#1049. Would this basically unblock the mirror CI? |
1100: Fix a python formatting issue raised by black r=Hoverbear a=Hoverbear Just a little whitespace! (See ferrocene/sphinx-shared-resources#46) 1103: let ci env vars propagate to setup-ubuntu.sh r=Hoverbear a=tshepang This fixes the issue where disk space was not freed. Should of been part of 3f84720. Co-authored-by: Ana Hobden <[email protected]> Co-authored-by: Tshepang Mbambo <[email protected]>
I am a bit confused with this. Your branch contains this file ferrocene_intersphinx_support.py. But no such file exists in ferrocene repo in the same |
That's my hope, yeah. |
5f32ef8
to
d0f318f
Compare
@amanjeev I did a better job this time I think. Mind taking another look? |
I think we missed one file deletion:
|
mirrored-commit: 79cfbf8b352b0611672aefbbe877d9584fc11d6c
d0f318f
to
7de064b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve this message.
bors merge |
I merged this given the intention of @Hoverbear with |
mirrored-commit: 8ac7393f92c3b9b16a6481488488ed04745c70c7