Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest mdbook and mdbook-mermaid #126

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

jonathanpallant
Copy link
Member

Please check output carefully. Ideally diff the HTML output to see what has changed.

@miguelraz
Copy link
Contributor

miguelraz commented Feb 1, 2024

I did a good visual inspection and a git diff --no-index _newbook book yields only changes to the scrollbox, which I think we can ignore.

I also get a

Warning: The mdbook-mermaid preprocessor was built against version 0.4.28 of mdbook, but we're being called from version 0.4.36

output in the console when building which I didn't know how to get rid of.

I don't think it's a blocker, so I'm approving.

@miguelraz miguelraz self-requested a review February 1, 2024 15:30
@jonathanpallant
Copy link
Member Author

cargo install mdbook-mermaid will, I think, update your mermaid plugin for mdbook.

@jonathanpallant jonathanpallant merged commit 6c44a33 into main Feb 1, 2024
2 checks passed
@jonathanpallant jonathanpallant deleted the update-mdbook-and-mermaid branch February 1, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants