This repository has been archived by the owner on Nov 24, 2022. It is now read-only.
Truncate config on writes #486
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for fgrehm#485.
glenux
added a commit
to glenux/contrib-vagrant-lxc
that referenced
this pull request
May 4, 2021
|
Hey, sorry for the silence here but this project is looking for maintainers 😅 As per #499, I've added the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #485. As per https://apidock.com/ruby/IO/open/class
File::RDWRseems to lackFile::TRUNC. Hence the call fromprune_customizationsdid nothing since it just overwrite the start of the file (which is presumably already untouched), but left theVAGRANT-BEGIN/VAGRANT-ENDblock that followed completely untouched.By adding
File::TRUNC,prune_customizationswill cause those tailing blocks to be removed as intended.