Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blogpost handling asynchronous tasks part2 #411

Merged
merged 15 commits into from
Jan 17, 2025

Conversation

Nlea
Copy link
Contributor

@Nlea Nlea commented Dec 13, 2024

No description provided.

Copy link

cloudflare-workers-and-pages bot commented Dec 18, 2024

Deploying fpx-www with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1a9861f
Status: ✅  Deploy successful!
Preview URL: https://75235287.fpx-www.pages.dev
Branch Preview URL: https://blogpost-handling-asynchrono.fpx-www.pages.dev

View logs

Copy link
Contributor

@brettimus brettimus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just did a first pass, going to review the part ii post now

@@ -35,7 +35,7 @@ In this example, we will store registration data in a [Neon database](https://ne
<LinkCard
title="Follow along on GitHub"
description="Here is a repo with the code examples for this post"
href="https://github.com/Nlea/cloudflare-handling-asynchronous-tasks-"
href="https://github.com/Nlea/cloudflare-handling-asynchronous-tasks-/tree/main/single-worker"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so a possible thing to do in the future: you can permalink to a specific point in time (commit) in your repo, so you won't have to update links in blog posts when you restructure the repo

@@ -36,7 +36,7 @@ Separately, and not as part of the registration process, you offer a newsletter
When an athlete subscribes to the newsletter, their email address is stored in a different database, and they receive a welcome email.

In this scenario, you could have three workers: one for handling the sign-up form, another for managing the newsletter subscription, and then a _shared_ email worker to send emails.
![Example Workers architecture](@/assets/blog/2024-12-03-workers-example-architecture.png)
![Example Workers architecture](@/assets/blog/2024-12-03-queue-architecture.png)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure you wanted to change this image? the queue architecture image doesn't seem to match the description of the preceding sentence

* Calculate uptime percentages
* Provide a RESTful API for managing monitored sites
* Include a simple web interface to view results
- Monitor multiple websites simultaneously
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i ran format on the astro codebase and that's what changed some of the stuff in this post, just fyi

@brettimus
Copy link
Contributor

brettimus commented Dec 18, 2024

I think we could publish this pretty much as-is if you're ready to move on.

Otherwise, if you're willing to do another pass, here are my thoughts:

I think we could trim down all the explanations of queues and various strategies for working with queues. Here's how you could maybe do that:

  • First, look at exactly what you want/need to implement to accomplish the email sending via a queue
  • Second, touch up the intro with a bulleted-list that explains what you're going to implement
  • Third, remove as much additional content on queues as possible, covering only the basics someone would need to know to understand what you're implementing
  • Fourth, rejig the conclusion to recap what you did (similar to the list in the intro)
  • Finally, save your learnings/explanations of queues somewhere, possibly for a bigger post on queues

Other notes:

  • The Service Bindings section flows well, but the transition into type safety is a lot, all of a sudden. Maybe move the type safety section to after the execution patterns, since it's more of an implementation detail.

  • The Queues section has good content but could benefit from a clearer distinction between the conceptual overview and the implementation details. Consider adding a brief overview paragraph before going into the setup.

  • The limitations section at the end feels a bit disconnected. Could add it a lil earlier when discussing local development, or frame it more clearly as "Development Considerations."

  • The conclusion effectively sets up Part 3, but could benefit from a stronger summary of the key takeaways from Part 2 before transitioning to the preview of Part 3.

@Nlea
Copy link
Contributor Author

Nlea commented Jan 13, 2025

@brettimus I tried my best to include your feedback. Could you give it a new read? That would be super helpful! Thanks

@Nlea Nlea merged commit 4063c5c into main Jan 17, 2025
3 checks passed
@Nlea Nlea deleted the blogpost-handling-asynchronous-tasks-part2 branch January 17, 2025 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants