Reduce the ECChain API surface by removing unused capability
#832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `ECChain` API offers a few functions that seem to only have been used in unit testing the functions themselves. Remove them to reduce LOC, in favor of adding back later if ever anyone asked for it.
masih
force-pushed
the
masih/chain-api-trim
branch
from
09a45ed to
56fb632
Compare
Kubuxu
approved these changes
Jan 16, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #832 +/- ##
==========================================
- Coverage 67.49% 67.32% -0.17%
==========================================
Files 84 84
Lines 8942 8915 -27
==========================================
- Hits 6035 6002 -33
- Misses 2380 2386 +6
Partials 527 527
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ECChainAPI offers a few functions that seem to only have been used in unit testing the functions themselves.Remove them to reduce LOC, in favor of adding back later if ever anyone asked for it.