Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GPBFT Trace log logging by pointer #867

Merged
merged 2 commits into from
Feb 3, 2025
Merged

Conversation

masih
Copy link
Member

@masih masih commented Feb 3, 2025

Since ECChain is changed to pointer at struct level log the proposal and vale directly. Otherwise, we get memory address to pointer in logs.

Since ECChain is changed to pointer at struct level log the proposal and
vale directly. Otherwise, we get memory address to pointer in logs.
@masih masih requested a review from rjan90 February 3, 2025 10:45
@masih masih enabled auto-merge February 3, 2025 10:59
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.20%. Comparing base (1e488a2) to head (f251351).
Report is 6 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #867      +/-   ##
==========================================
+ Coverage   67.16%   67.20%   +0.03%     
==========================================
  Files          83       84       +1     
  Lines        9064     9139      +75     
==========================================
+ Hits         6088     6142      +54     
- Misses       2429     2457      +28     
+ Partials      547      540       -7     
Files with missing lines Coverage Δ
gpbft/gpbft.go 89.97% <100.00%> (ø)

... and 11 files with indirect coverage changes

@masih masih added this pull request to the merge queue Feb 3, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 3, 2025
@masih masih enabled auto-merge February 3, 2025 11:27
@masih masih self-assigned this Feb 3, 2025
@masih masih added this to the M2: Mainnet Passive Testing milestone Feb 3, 2025
@masih masih added this pull request to the merge queue Feb 3, 2025
Merged via the queue into main with commit 740dd94 Feb 3, 2025
14 checks passed
@masih masih deleted the masih/fix-gpbft-log-ref branch February 3, 2025 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants