add comment to explain the skip of gap range

filodb · Jan 17, 2025 · 0de4e7c · 0de4e7c
1 parent 276ad42
commit 0de4e7c
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/coordinator/src/main/scala/filodb.coordinator/queryplanner/MultiPartitionPlanner.scala b/coordinator/src/main/scala/filodb.coordinator/queryplanner/MultiPartitionPlanner.scala
@@ -734,7 +734,9 @@ class MultiPartitionPlanner(val partitionLocationProvider: PartitionLocationProv
             case None           => (lastTimeRange.endMs, timeRange.endMs)
           }
           if (gapStartTimeMs <= gapEndTimeMs){
-            // Check if there is a gap
+            // The opposite happens when we snap a large step to the query start and the result/gapStartTimeMs is
+            // larger than the query end time/gapEndTimeMs. That means there is no gap so we skip this block of code
+            // for handling gap range
             val newParams = qParams.copy(startSecs = gapStartTimeMs / 1000, endSecs = gapEndTimeMs / 1000)
             val newContext = qContext.copy(origQueryParams = newParams)
             val newLp = rewritePlanWithRemoteRawExport(logicalPlan,