feat(query) Support split partition raw queries #1677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alextheimer
reviewed
Oct 1, 2023
coordinator/src/main/scala/filodb.coordinator/queryplanner/MultiPartitionPlanner.scala
Show resolved
Hide resolved
alextheimer
reviewed
Oct 1, 2023
coordinator/src/main/scala/filodb.coordinator/queryplanner/MultiPartitionPlanner.scala
Outdated
Show resolved
Hide resolved
alextheimer
reviewed
Jan 1, 2024
There was a problem hiding this comment.
Just a few comments/questions. Thanks for handling this @amolnayak311 -- it doesn't look like it was easy to get the timestamps exactly right.
coordinator/src/main/scala/filodb.coordinator/queryplanner/DefaultPlanner.scala
Show resolved
Hide resolved
coordinator/src/main/scala/filodb.coordinator/queryplanner/DefaultPlanner.scala
Show resolved
Hide resolved
coordinator/src/main/scala/filodb.coordinator/queryplanner/DefaultPlanner.scala
Outdated
Show resolved
Hide resolved
coordinator/src/main/scala/filodb.coordinator/queryplanner/DefaultPlanner.scala
Show resolved
Hide resolved
coordinator/src/main/scala/filodb.coordinator/queryplanner/DefaultPlanner.scala
Show resolved
Hide resolved
coordinator/src/test/scala/filodb.coordinator/queryplanner/PlannerHierarchySpec.scala
Outdated
Show resolved
Hide resolved
coordinator/src/test/scala/filodb.coordinator/queryplanner/PlannerHierarchySpec.scala
Outdated
Show resolved
Hide resolved
coordinator/src/test/scala/filodb.coordinator/queryplanner/MultiPartitionPlannerSpec.scala
Show resolved
Hide resolved
coordinator/src/test/scala/filodb.coordinator/queryplanner/MultiPartitionPlannerSpec.scala
Show resolved
Hide resolved
alextheimer
reviewed
Jan 5, 2024
alextheimer
reviewed
Jan 5, 2024
coordinator/src/main/scala/filodb.coordinator/queryplanner/MultiPartitionPlanner.scala
Outdated
Show resolved
Hide resolved
alextheimer
reviewed
Jan 6, 2024
| @@ -85,4 +87,5 @@ case class QueryConfig(askTimeout: FiniteDuration, | |||
| plannerSelector: Option[String] = None, | |||
| recordContainerOverrides: Map[String, Int] = Map.empty, | |||
| supportRemoteRawExport: Boolean = false, | |||
| maxRemoteRawExportTimeRange: FiniteDuration = 3 days) | |||
| maxRemoteRawExportTimeRange: FiniteDuration = 3 days, | |||
| enableApproximatelyEqualCheckInStitch: Boolean = true) | |||
There was a problem hiding this comment.
Should this be:
queryConfig.getBoolean("routing.enable-approximate-equals-in-stitch")
?
alextheimer
approved these changes
Jan 6, 2024
There was a problem hiding this comment.
Thanks for addressing all comments @amolnayak311
PR looks good 👍 -- please see the one comment I've left, and feel free to merge if no action is needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
Current behavior :
Whenever a query spans across partitions, there is a gap in results for the range queries where lookbacks/offsets span multiple partitions.
New behavior :
The PR is a draft for the WIP to achieve 0 downtime for queries when there are time-split partitions.