Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix unary expressions. #1697

Merged
merged 2 commits into from
Dec 20, 2023
Merged

fix unary expressions. #1697

merged 2 commits into from
Dec 20, 2023

Conversation

yu-shipit
Copy link
Contributor

@yu-shipit yu-shipit commented Dec 14, 2023

  1. support queries with multiple unary sign such as -+--foo
  2. fix rhs scalar unary expression. Basically, the right plan for this case should be ScalarBinaryOperationExec instead of BinaryJoinExec.

Pull Request checklist

  • The commit(s) message(s) follows the contribution guidelines ?
  • Tests for the changes have been added (for bug fixes / features) ?
  • Docs have been added / updated (for bug fixes / features) ?

Current behavior : (link exiting issues here : https://help.github.com/articles/basic-writing-and-formatting-syntax/#referencing-issues-and-pull-requests)

  1. do not handle RHS unary expression properly.
  2. do not support multiple unary expressions.

New behavior :
can handle queries like foo > -1
support queries with multiple unary signs like ---foo > -+-1

BREAKING CHANGES

If this PR contains a breaking change, please describe the impact and migration
path for existing applications.
If not please remove this section.

Breaking changes may include:

  • Any schema changes to any Cassandra tables
  • The serialized format for Dataset and Column (see .toString methods)
  • Over the wire formats for Akka messages / case classes
  • Changes to the HTTP public API
  • Changes to query parsing / PromQL parsing

Other information:

1. support queries with multiple unary sign such as -+--foo
2. fix rhs scalar unary expression. Basically, the right plan for this case should be
ScalarBinaryOperationExec instead of BinaryJoinExec.
alextheimer
alextheimer previously approved these changes Dec 15, 2023
Copy link
Contributor

@alextheimer alextheimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved -- please see the comments for a couple questions/test-suggestions.

Copy link
Contributor

@alextheimer alextheimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates @yu-shipit 🙏

@yu-shipit yu-shipit merged commit 22e83d0 into filodb:develop Dec 20, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants