Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge integration to main. #1935

Merged
merged 11 commits into from
Jan 22, 2025
Merged

merge integration to main. #1935

merged 11 commits into from
Jan 22, 2025

Conversation

yu-shipit
Copy link
Contributor

Pull Request checklist

  • The commit(s) message(s) follows the contribution guidelines ?
  • Tests for the changes have been added (for bug fixes / features) ?
  • Docs have been added / updated (for bug fixes / features) ?

Current behavior : (link exiting issues here : https://help.github.com/articles/basic-writing-and-formatting-syntax/#referencing-issues-and-pull-requests)

New behavior :

BREAKING CHANGES

If this PR contains a breaking change, please describe the impact and migration
path for existing applications.
If not please remove this section.

Breaking changes may include:

  • Any schema changes to any Cassandra tables
  • The serialized format for Dataset and Column (see .toString methods)
  • Over the wire formats for Akka messages / case classes
  • Changes to the HTTP public API
  • Changes to query parsing / PromQL parsing

Other information:

sandeep6189 and others added 10 commits January 15, 2025 09:56
The rows() is a closable resources. We can use Using to protect it.
However, the current logic calls rows() twice and only close it once.
This commit would fix this issue.

Co-authored-by: Yu Zhang <[email protected]>
RepeatTransformer should be added as a case.

Co-authored-by: Yu Zhang <[email protected]>
…needed (filodb#1934)

* Planning for local and remote clusters only if absolutely needed.

* fixing scalastyle

---------

Co-authored-by: Kier Petrov <[email protected]>
…ilodb#1932)

* query(fix) schema mismatch due to different length of data points.

Some number of data points are different for different time series.
Use the longer length as the result.
---------

Co-authored-by: Yu Zhang <[email protected]>
fix (query): cherry picking ensure that legacy failover stays legacy failover
kvpetrov
kvpetrov previously approved these changes Jan 22, 2025
Copy link
Contributor

@kvpetrov kvpetrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yu-shipit yu-shipit merged commit 855c4e9 into filodb:main Jan 22, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants