Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building snapshot for extend + pivot operation (part 2 of roundtrip) #3800

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

gs-gunjan
Copy link
Contributor

@gs-gunjan gs-gunjan commented Jan 9, 2025

Snapshot building for extend + pivot operation
Cleanup for filter operation

Summary

How did you test this change?

  • Test(s) added
  • Manual testing (please provide screenshots/recordings)
  • No testing (please provide an explanation)

Adding validation operation for groupBy
Copy link

changeset-bot bot commented Jan 9, 2025

🦋 Changeset detected

Latest commit: 2d51bcb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 28 packages
Name Type
@finos/legend-data-cube Patch
@finos/legend-application-data-cube-bootstrap Patch
@finos/legend-application-data-cube Patch
@finos/legend-application-query Patch
@finos/legend-application-repl Patch
@finos/legend-application-studio Patch
@finos/legend-query-builder Patch
@finos/legend-vscode-extension-dependencies Patch
@finos/legend-application-data-cube-deployment Patch
@finos/legend-application-query-bootstrap Patch
@finos/legend-extension-dsl-service Patch
@finos/legend-application-repl-deployment Patch
@finos/legend-application-studio-bootstrap Patch
@finos/legend-extension-assortment Patch
@finos/legend-extension-dsl-data-quality Patch
@finos/legend-extension-dsl-data-space-studio Patch
@finos/legend-extension-dsl-diagram Patch
@finos/legend-extension-dsl-persistence Patch
@finos/legend-extension-dsl-text Patch
@finos/legend-extension-store-flat-data Patch
@finos/legend-extension-store-relational Patch
@finos/legend-extension-store-service-store Patch
@finos/legend-extension-dsl-data-space Patch
@finos/legend-application-query-deployment Patch
@finos/legend-application-studio-deployment Patch
@finos/legend-application-pure-ide Patch
@finos/legend-application-pure-ide-deployment Patch
@finos/legend-server-showcase-deployment Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 60.62581% with 302 lines in your changes missing coverage. Please review.

Project coverage is 45.24%. Comparing base (6711f1e) to head (2d51bcb).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
...c/stores/core/DataCubeQuerySnapshotBuilderUtils.ts 54.43% 76 Missing and 1 partial ⚠️
...eryFilterOperation__EqualCaseInsensitiveColumn.tsx 26.66% 22 Missing ⚠️
...FilterOperation__NotEqualCaseInsensitiveColumn.tsx 37.14% 22 Missing ⚠️
...beQueryFilterOperation__ContainCaseInsensitive.tsx 44.44% 15 Missing ⚠️
...CubeQueryFilterOperation__EqualCaseInsensitive.tsx 44.44% 15 Missing ⚠️
...QueryFilterOperation__StartWithCaseInsensitive.tsx 44.44% 15 Missing ⚠️
...ataCubeQueryFilterOperation__GreaterThanColumn.tsx 18.75% 13 Missing ⚠️
...r/DataCubeQueryFilterOperation__LessThanColumn.tsx 18.75% 13 Missing ⚠️
...ubeQueryFilterOperation__LessThanOrEqualColumn.tsx 38.09% 13 Missing ⚠️
...e/filter/DataCubeQueryFilterOperation__Contain.tsx 23.07% 10 Missing ⚠️
... and 16 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3800      +/-   ##
==========================================
+ Coverage   45.22%   45.24%   +0.02%     
==========================================
  Files        2245     2245              
  Lines      390298   390507     +209     
  Branches    16501    16615     +114     
==========================================
+ Hits       176514   176699     +185     
- Misses     212758   212777      +19     
- Partials     1026     1031       +5     
Files with missing lines Coverage Δ
...re/filter/DataCubeQueryFilterOperation__IsNull.tsx 73.46% <100.00%> (+1.12%) ⬆️
.../filter/DataCubeQueryFilterOperation__NotEqual.tsx 76.80% <100.00%> (+2.46%) ⬆️
...r/DataCubeQueryFilterOperation__NotEqualColumn.tsx 79.83% <100.00%> (+2.05%) ⬆️
...beQueryFilterOperation__EndWithCaseInsensitive.tsx 83.87% <96.29%> (+1.79%) ⬆️
...ore/filter/DataCubeQueryFilterOperation__Equal.tsx 73.91% <92.30%> (-10.58%) ⬇️
...taCubeQueryFilterOperation__GreaterThanOrEqual.tsx 76.27% <94.44%> (+1.27%) ⬆️
...eQueryFilterOperation__NotEqualCaseInsensitive.tsx 84.84% <96.87%> (+2.27%) ⬆️
...filter/DataCubeQueryFilterOperation__StartWith.tsx 80.95% <92.30%> (+14.95%) ⬆️
...e/filter/DataCubeQueryFilterOperation__EndWith.tsx 74.28% <76.92%> (+8.28%) ⬆️
...ilter/DataCubeQueryFilterOperation__NotEndWith.tsx 74.78% <85.71%> (+9.73%) ⬆️
... and 19 more

... and 33 files with indirect coverage changes

@@ -24,6 +24,17 @@ export type DataCubeQuerySnapshotBuilderTestCase = [
string | undefined, // error
];

export type OperationSnapshotAnalysisTestCase = [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's prefix them with DataCube... and we can combine them, if 3rd param is provided, we do the check differently.

@gs-gunjan gs-gunjan changed the title Building snapshot for extend operation (part 2 of roundtrip) Building snapshot for extend + pivot operation (part 2 of roundtrip) Jan 10, 2025
@gs-gunjan gs-gunjan marked this pull request as ready for review January 10, 2025 13:06
@gs-gunjan gs-gunjan requested a review from a team as a code owner January 10, 2025 13:06
@gs-gunjan
Copy link
Contributor Author

gs-gunjan commented Jan 10, 2025

Screenshot 2025-01-10 at 6 40 19 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants