Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try a different approach to parallel tests #3978

Merged
merged 23 commits into from
Jan 21, 2025
Merged
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
4109283
Fix test for mixed-ness in Function.sub, and fix Cofunction.sub to ma…
JHopeCollins Jan 9, 2025
8e1a748
Temp fix for firedrake install on Mac for Xcode16 (#3964)
Ig-dolci Jan 10, 2025
a08fc1e
Untangle compilation process (#3940)
connorjward Jan 10, 2025
5c6e320
Configure PETSc with --with-strict-petscerrorcode (#3962)
connorjward Jan 10, 2025
ff55c4c
extra / (#3970)
rckirby Jan 13, 2025
723ca72
add link to student support form (#3974)
rckirby Jan 14, 2025
cbfc2b2
Preserve default mesh name after Netgen mesh creation (#3951)
MohamedAlyLoutfy Jan 15, 2025
cd68f9d
Add functionality to print patch statistics in ASMStarPC and friends …
pefarrell Jan 15, 2025
ad9fe2c
Test high order CR and variants (#3969)
pbrubeck Jan 15, 2025
9c5ec2f
Fieldsplit: replace empty Forms with ZeroBaseForm (#3947)
pbrubeck Jan 15, 2025
1ae8c4b
try another parallel testing approach
connorjward Jan 16, 2025
b6f76d5
Merge remote-tracking branch 'origin/master' into connorjward/avoid-c…
connorjward Jan 16, 2025
e052e2e
silly sudo error
connorjward Jan 16, 2025
4cf20cb
fixup
connorjward Jan 16, 2025
edc288b
fixup
connorjward Jan 16, 2025
7fb13ab
try again
connorjward Jan 16, 2025
07b57d7
fixup?
connorjward Jan 16, 2025
8b82c4d
bad linting but correct I think, escaping is hard
connorjward Jan 16, 2025
2a6c83a
Re-enable all tests
connorjward Jan 16, 2025
5a56d8a
fixups, make sure taping is disabled after each test
connorjward Jan 17, 2025
27ec0b2
fixup
connorjward Jan 20, 2025
51b810c
fixup
connorjward Jan 21, 2025
3a99214
fixup
connorjward Jan 21, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Preserve default mesh name after Netgen mesh creation (#3951)
* Preserve  default mesh name after Netgen mesh creation to avoid checkpointing errors

* Ensure consistent handling of mesh and topology names for Netgen and non-Netgen meshes
MohamedAlyLoutfy authored Jan 15, 2025
commit cbfc2b2f359a2524b0871ead22e6b297fe8929ff
6 changes: 4 additions & 2 deletions firedrake/mesh.py
Original file line number Diff line number Diff line change
@@ -3073,6 +3073,7 @@ def Mesh(meshfile, **kwargs):
netgen_flags = kwargs.get("netgen_flags", {"quad": False, "transform": None, "purify_to_tets": False})
netgen_firedrake_mesh = FiredrakeMesh(meshfile, netgen_flags, user_comm)
plex = netgen_firedrake_mesh.meshMap.petscPlex
plex.setName(_generate_default_mesh_topology_name(name))
else:
basename, ext = os.path.splitext(meshfile)
if ext.lower() in ['.e', '.exo']:
@@ -3099,10 +3100,11 @@ def Mesh(meshfile, **kwargs):
distribution_name=kwargs.get("distribution_name"),
permutation_name=kwargs.get("permutation_name"),
comm=user_comm)
mesh = make_mesh_from_mesh_topology(topology, name)
if netgen and isinstance(meshfile, netgen.libngpy._meshing.Mesh):
netgen_firedrake_mesh.createFromTopology(topology, name=plex.getName(), comm=user_comm)
netgen_firedrake_mesh.createFromTopology(topology, name=name, comm=user_comm)
mesh = netgen_firedrake_mesh.firedrakeMesh
else:
mesh = make_mesh_from_mesh_topology(topology, name)
mesh._tolerance = tolerance
return mesh