[Story/TP-57214]:Prevent reuse of Password reset token #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emborden
changed the title
vstehlik
reviewed
Jan 9, 2020
| @@ -1,5 +1,5 @@ | |||
| # frozen_string_literal: true | |||
|
|
|||
| class Hedgelog | |||
| VERSION = '0.1.12' | |||
| VERSION = '0.2.1.alpha1' | |||
There was a problem hiding this comment.
For future reference standard naming would be to reset the lower significance number when publishing. Since this is a minor version bump, the patch version should be reset, i.e. 0.2.0.alpha.1
There was a problem hiding this comment.
it was meant to be 0.2.0.alpha1, but when I published I published as just 0.2.0 on accident. So I bumped to 0.2.1.alpha1. to show I was in beta testing, and because of so that minor changes I made to pass spec and rubocop
vstehlik
reviewed
Jan 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Topic
TP Link: https://sbf.tpondemand.com/entity/57214
SBF PR: firespring/SBF#1598
How to test
create a log in
api:consolecreate a log with filters and password to a hash notice that the hash will filter the content that is passed in the stringSetup
rake switch BRANCH=story/TP-57214Functionality