This repository has been archived by the owner on Nov 19, 2024. It is now read-only.
Changed vars and some titles #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dholms
reviewed
Dec 10, 2019
| @@ -20,7 +20,7 @@ | |||
| "typescript": "3.7.2" | |||
| }, | |||
| "scripts": { | |||
| "start": "react-scripts start", | |||
| "start": "HOST=0.0.0.0 react-scripts start", | |||
There was a problem hiding this comment.
why is this necessary? seems to start fine on localhost for me
There was a problem hiding this comment.
ah just saw your other issue. disregard :)
dholms
reviewed
Dec 10, 2019
| export const ipfsProvider = process.env.REACT_APP_INTERPLANETARY_FISSION_URL || 'https://hostless.dev'; | ||
| const username = process.env.REACT_APP_INTERPLANETARY_FISSION_USERNAME; | ||
| const password = process.env.REACT_APP_INTERPLANETARY_FISSION_PASSWORD; | ||
| export const ipfsProvider = process.env.INTERPLANETARY_FISSION_URL || 'https://runfission.com'; |
There was a problem hiding this comment.
the REACT_APP_ here is actually intentional. Otherwise react can't find the env variables: #12 (comment)
There was a problem hiding this comment.
Ok. But in Heroku, from our add-on, it is without REACT_APP. Does it just do this automatically?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main change is to use the correct default Heroku variable names (and removed REACT_APP_ from in front of elsewhere that I found it), added some names / titles in a couple of spots,