add dedicated basic module status - hooks disabled #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mikhail Scherba <[email protected]>
miklezzzz
force-pushed
the
add-hooks-disabled-module-satus
branch
from
8daf6f7 to
b7482b2
Compare
Merged
4 tasks
yalosev
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pr introduces an additional module state:
HooksDisabled. In some situations it makes sense to disable a module hooks (mostly before deleting or when updating the module) and this state would allow reflecting the module status appropriately.What this PR does / why we need it
Thir pr adds an additional module state
HooksDisabledand updates a module state accordingly when the moduleManager'sDisableModuleHooksmethod is invocated.Special notes for your reviewer