-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[addon-operator] add sdk and batch hooks #529
Conversation
5714cce
to
60c9f87
Compare
b5eb36e
to
e33ff1e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and a global question - what was wrong about using Public variables from the App package comparing to forwarding the same values via arguments to functions/methods?
Global variables are appropriate when we use them as a singleton (IMHO any singleton is a design error, and we should strive to exclude it from the code base). In our case, global vars are used only to read flags. Due to the fact that we directly throw them inside our functions, we have high coupling. |
ba0d01c
to
6eee0f7
Compare
Signed-off-by: Pavel Okhlopkov <[email protected]>
90f2fc0
to
c444cd3
Compare
Signed-off-by: Pavel Okhlopkov <[email protected]>
Signed-off-by: Pavel Okhlopkov <[email protected]>
Signed-off-by: Pavel Okhlopkov <[email protected]>
Signed-off-by: Pavel Okhlopkov <[email protected]>
Signed-off-by: Pavel Okhlopkov <[email protected]>
Signed-off-by: Pavel Okhlopkov <[email protected]>
Signed-off-by: Pavel Okhlopkov <[email protected]>
Signed-off-by: Pavel Okhlopkov <[email protected]>
Signed-off-by: Pavel Okhlopkov <[email protected]>
Signed-off-by: Pavel Okhlopkov <[email protected]>
Signed-off-by: Pavel Okhlopkov <[email protected]>
Signed-off-by: Pavel Okhlopkov <[email protected]>
Signed-off-by: Pavel Okhlopkov <[email protected]>
3f87d4e
to
0892c54
Compare
Signed-off-by: Pavel Okhlopkov <[email protected]>
Overview
Refactoring of global values
Replace snake_case names
Bump shell-operator
Add new module type (now we have EmbeddedModule and Module)
Add interface PatchCollector
Add interface TaskMetadata
Add Batch Hook logic
What this PR does / why we need it
Special notes for your reviewer