-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Process only increasing block numbers #284
base: develop
Are you sure you want to change the base?
Conversation
Benchmark results for
|
Date (UTC) | 2024-12-12T21:34:33+00:00 |
Commit | 0327a7ec1db898438a29486cae9bd3b31217fc80 |
Base SHA | 16290b62a7b1a7693b04589ce403013bee09b20b |
Significant changes
None
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure about this one, in particular rejecting "the same block number".
IIRC CL sends 2 events per slot so it can be the case that the second one is actually "correct".
Also, is this place in the code is actually a problem? The way it works is that it just sends all events to the builder and then builder only builds on the events that have parent hash that reth hash synced. So it kind of sorted out already, even thought not directly.
I think we can have any parent (it's just a historic block) but the real failure occurs on the root hash which, from what I undestand, can only be computed on the head. But we don't do root hash until we bid and that's too close to the slot start. |
I think its too risky but without good argument, just on the feel level. Also, we do wait for the parent header to be correct before even starting the block building. Maybe we can make that check harder to pass for events that we can't even build on. |
## 📝 Summary #286 included some changes by mistake. These changes are still under consideration in #284. We will wait until we have more info. ## 💡 Motivation and Context "Active slots" metric was lower than usual. --- ## ✅ I have completed the following steps: * [X] Run `make lint` * [X] Run `make test` * [ ] Added tests (if applicable)
📝 Summary
Instead of processing anything that comes from the CL we only process increasing block numbers.
💡 Motivation and Context
I've seen some really crazy sequences from the CL (eg: repeated block numbers, going back) and the builder is not really suited right now to build simultaneous blocks (the good one and some trash).
✅ I have completed the following steps:
make lint
make test