Add StateProviderFactory custom trait #331
Conversation
Benchmark results for
|
| Date (UTC) | 2025-01-09T16:55:46+00:00 |
| Commit | 94d042e248ab66754a19c3434b26ffed13bfe8d2 |
| Base SHA | 26db62de834397c04fbe105f900e393bb6d28f87 |
Significant changes
| Benchmark | Mean | Status |
|---|---|---|
| reference_trie_insert_and_hash_3000 | 2.58% | Performance has degraded. |
| hashing_3000_elements | 2.88% | Performance has degraded. |
ferranbt
requested review from
dvush,
ZanCorDX,
liamaharon and
metachris
as code owners
| @@ -0,0 +1,43 @@ | |||
| use crate::live_builder::simulation::SimulatedOrderCommand; | |||
There was a problem hiding this comment.
Doc comment would be nice
crates/rbuilder/src/provider/mod.rs
Outdated
|
|
||
| pub mod reth_prov; | ||
|
|
||
| pub trait StateProviderFactory: Clone + 'static + Send + Sync { |
There was a problem hiding this comment.
Can we name this something different so it doesn't get confused with the reth StateProviderFactory? Maybe RbuilderProvider?
crates/rbuilder/src/provider/mod.rs
Outdated
|
|
||
| pub mod reth_prov; | ||
|
|
||
| pub trait StateProviderFactory: Clone + 'static + Send + Sync { |
crates/rbuilder/src/provider/mod.rs
Outdated
|
|
||
| pub mod reth_prov; | ||
|
|
||
| pub trait StateProviderFactory: Clone + 'static + Send + Sync { |
There was a problem hiding this comment.
Clone + 'static doesn't seem right, it feels more like specific use constrains you brought to the trait.
crates/rbuilder/src/provider/mod.rs
Outdated
| fn run_trie_prefetcher( | ||
| &self, | ||
| parent_hash: B256, | ||
| simulated_orders: broadcast::Receiver<SimulatedOrderCommand>, | ||
| cancel: CancellationToken, | ||
| ); |
crates/rbuilder/src/provider/mod.rs
Outdated
| fn calculate_state_root( | ||
| &self, | ||
| parent_hash: B256, | ||
| outcome: &ExecutionOutcome, | ||
| config: RootHashConfig, | ||
| ) -> Result<B256, RootHashError>; |
There was a problem hiding this comment.
If feels like the specifics of roothash calculation should be hidden (eg: RootHashConfig) inside the specific implementation and not in the trait (and they are probably going to be constant during the while execution!)
|
All the Default::default() for the SparseTrieSharedCache broke the whole caching thing. This must be carefully rethought or it will not work. |
| @@ -169,23 +168,47 @@ impl BaseConfig { | |||
| )) | |||
| } | |||
|
|
|||
| /// WARN: opens reth db | |||
| pub async fn create_builder<SlotSourceType>( | |||
There was a problem hiding this comment.
I removed this method in #330
| @@ -0,0 +1,77 @@ | |||
| use super::OrderInputConfig; | |||
There was a problem hiding this comment.
This file was removed in #327?
📝 Summary
💡 Motivation and Context
✅ I have completed the following steps:
make lintmake test