generators: Don't write files other than unit files #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pothos
added a commit
to flatcar/scripts
that referenced
this pull request
Jan 22, 2024
This pulls in flatcar/bootengine#84 to prepare for a systemd update.
2 tasks
Systemd now executes generators in a sandbox to make sure they only generate units and don't have other side effects: https://github.com/systemd/systemd/blob/166bcaf95fbdd036f99705d2204138c36eb95836/NEWS#L1583 Port our generator usage to comply with the new behavior so that we can update our systemd version. Move the Ignition preparations into the ignition-setup script, setup the fsck overwrite unit at install time, and remove the mkdir calls because Mount units will do this when needed.
pothos
force-pushed
the
kai/generator-cleanup
branch
from
7be7baa to
dd8c70b
Compare
pothos
added a commit
to flatcar/scripts
that referenced
this pull request
Jan 22, 2024
This pulls in flatcar/bootengine#84 to prepare for a systemd update.
krnowak
reviewed
Jan 23, 2024
Comment on lines
+20
to
+26
| # Set up by 10usr-generator/module-setup.sh | ||
| [Unit] | ||
| DefaultDependencies=no | ||
| [Service] | ||
| Type=oneshot | ||
| RemainAfterExit=yes | ||
| ExecStart=true |
There was a problem hiding this comment.
I'm wondering if this should be kept more-or-less in sync with systemd - upstream seems to have more stuff in the unit.
There was a problem hiding this comment.
Or maybe we should carry a patch to systemd, so no overwriting needs to be done here?
There was a problem hiding this comment.
This is a minimal unit, to have it start instead of masking it. What we would need upstream is a way of resetting the After= dependencies through a drop-in…
krnowak
approved these changes
Jan 24, 2024
pothos
added a commit
to flatcar/scripts
that referenced
this pull request
Jan 24, 2024
This pulls in flatcar/bootengine#84 to prepare for a systemd update.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Systemd now executes generators in a sandbox to make sure they only generate units and don't have other side effects:
https://github.com/systemd/systemd/blob/166bcaf95fbdd036f99705d2204138c36eb95836/NEWS#L1583
Port our generator usage to comply with the new behavior so that we can
update our systemd version. Move the Ignition preparations into the
ignition-setup script, setup the fsck overwrite unit at install time,
and remove the mkdir calls because Mount units will do this when needed.
How to use
Testing done
see scripts PR