Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

utils: Ignore non-Linux screenshots #4106

Merged
merged 3 commits into from
Nov 6, 2024
Merged

utils: Ignore non-Linux screenshots #4106

merged 3 commits into from
Nov 6, 2024

Conversation

bbhtt
Copy link
Contributor

@bbhtt bbhtt commented Nov 5, 2024 •
edited by razzeee
Loading

Fixes #4105

@bbhtt
Copy link
Contributor Author

bbhtt commented Nov 5, 2024

greenlet does not build with python 3.13

@bbhtt bbhtt force-pushed the bbhtt/ignore-sc-env branch 2 times, most recently from 921f9d4 to b016024 Compare November 5, 2024 17:55
@razzeee
Copy link
Member

razzeee commented Nov 5, 2024

I would prefer to not have is_linux exposed in the end, as it doesn't seem of much value?

@bbhtt
Copy link
Contributor Author

bbhtt commented Nov 5, 2024 •
edited
Loading

I would prefer to not have is_linux exposed in the end, as it doesn't seem of much value?

Hm maybe I can expose environment instead directly. Seems like it will me more useful than this.

@bbhtt bbhtt force-pushed the bbhtt/ignore-sc-env branch 2 times, most recently from 6468852 to 45ce2b5 Compare November 5, 2024 20:24
@razzeee
Copy link
Member

razzeee commented Nov 5, 2024

Should be good to go, optional things I can think of:

  1. Omit null, when not set (save data on api requests)
  2. Have a test, that consumes macos/windows screenshots and check, if they are removed

@bbhtt bbhtt force-pushed the bbhtt/ignore-sc-env branch from 45ce2b5 to 6859851 Compare November 6, 2024 03:00
@bbhtt bbhtt force-pushed the bbhtt/ignore-sc-env branch from 6859851 to cf8b641 Compare November 6, 2024 03:06
@razzeee
Copy link
Member

razzeee commented Nov 6, 2024

Thank you

@razzeee razzeee merged commit fa2d75d into flathub-infra:main Nov 6, 2024
2 checks passed
@bbhtt bbhtt deleted the bbhtt/ignore-sc-env branch November 6, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Do not display screenshots with environment="windows"
2 participants
@bbhtt @razzeee