Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid forwarding all notification file desciptors to backend #1478

Merged
merged 3 commits into from
Oct 22, 2024

Conversation

jadahl
Copy link
Collaborator

@jadahl jadahl commented Oct 18, 2024

Main commit:

    notification: Use separate fd list for input and output
    
    Doing this means we don't unnecessarily forward file descriptors that
    weren't intended to be passed along.
    
    For the notification portal, this avoids forwarding file descriptors
    from the app to the backend that were dropped due to being placed in an
    unsupported property.

I haven't tested this yet, I just ran the tests.

@swick
Copy link
Contributor

swick commented Oct 18, 2024

LGTM but CI is currently a bit weird because it requires the image in the repository of the user of the pull request. If you force push again it should get green.

Doing this means we don't unnecessarily forward file descriptors that
weren't intended to be passed along.

For the notification portal, this avoids forwarding file descriptors
from the app to the backend that were dropped due to being placed in an
unsupported property.
@jadahl jadahl force-pushed the wip/notification-fixes branch from e935ce0 to 76b8850 Compare October 21, 2024 10:48
@GeorgesStavracas GeorgesStavracas added this to the 1.20 milestone Oct 22, 2024
@GeorgesStavracas GeorgesStavracas added this pull request to the merge queue Oct 22, 2024
Merged via the queue into flatpak:main with commit 25ee11e Oct 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Triaged
Development

Successfully merging this pull request may close these issues.

3 participants