Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Prefer repository owner image if it exists #1480

Merged
merged 1 commit into from
Oct 19, 2024

Conversation

swick
Copy link
Contributor

@swick swick commented Oct 18, 2024

Only fall back to the actor's image if the repository owner ones does not exist.

@swick
Copy link
Contributor Author

swick commented Oct 18, 2024

You can see the action started by this PR now used the image ghcr.io/flatpak/xdg-desktop-portal:20241016-2 because it already exists. (https://github.com/flatpak/xdg-desktop-portal/actions/runs/11405007518)

@swick swick force-pushed the wip/ci-container-image-src branch from bb0535e to aa037d5 Compare October 18, 2024 13:53
@swick
Copy link
Contributor Author

swick commented Oct 18, 2024

Amended the commit with a bumped tag and now the action is using the image ghcr.io/swick/xdg-desktop-portal:20241016-3 because it does not exist in the flatpak registry but in mine. (https://github.com/flatpak/xdg-desktop-portal/actions/runs/11405052580)

The only case which will still not work great is if a PR is created which bumps the tag and before an action in your own repo finished building the image, but that's much better than what we have right now.

Only fall back to the actor's image if the repository owner ones does
not exist.
@swick swick force-pushed the wip/ci-container-image-src branch from aa037d5 to 642f605 Compare October 18, 2024 13:56
@GeorgesStavracas GeorgesStavracas added this to the 1.20 milestone Oct 19, 2024
@GeorgesStavracas GeorgesStavracas added this pull request to the merge queue Oct 19, 2024
Merged via the queue into flatpak:main with commit 7160b5c Oct 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Triaged
Development

Successfully merging this pull request may close these issues.

2 participants