Add python tests for all portals that have a C test #1524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swick
force-pushed
the
wip/pytest-conversion
branch
7 times, most recently
from
1e63f82 to
76a9440
Compare
swick
force-pushed
the
wip/pytest-conversion
branch
from
76a9440 to
7f0634a
Compare
|
Rebased on top of #1523 again. |
swick
force-pushed
the
wip/pytest-conversion
branch
from
7f0634a to
dba71c9
Compare
|
Rebased on main. Should be ready to review. |
The camera tests require a backend for access and lockdown, so add them as well.
This will be useful for the notification portal and the permission store tests because they require complex typed arguments and async calls.
The pytest harness already knows how to set up all the portal bits and pieces so we can drop the shell script and the dbus service activation configuration.
swick
force-pushed
the
wip/pytest-conversion
branch
from
dba71c9 to
16bc688
Compare
|
Rebased on main which now has the python settings test (#1538). |
GeorgesStavracas
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #1523
This PR adds tests using the pytest harness for every integration test that we have.
The C unit tests
testdbandtest-xdp-utilswill stay.The C integration tests remain for now to give us some time to make sure everything is working as intended and to improve logging and debugging for the pytest harness. The idea is to remove them eventually.