Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build/tests: Check for python found and version in single require call #1548

Merged

Conversation

swick
Copy link
Contributor

@swick swick commented Dec 23, 2024

We can only use the python object if it was found and the arguments for require are all evaluated, even if the resulting feature is disabled.

Fixes: 1c6dd18 ("tests: Check for required WAV decoder for notification tests")
Closes: #1547

We can only use the python object if it was found and the arguments for
require are all evaluated, even if the resulting feature is disabled.

Fixes: 1c6dd18 ("tests: Check for required WAV decoder for notification tests")
Closes: flatpak#1547
@GeorgesStavracas GeorgesStavracas added this to the 1.20 milestone Jan 7, 2025
@GeorgesStavracas GeorgesStavracas added the build system Issues with the build system label Jan 7, 2025
@GeorgesStavracas GeorgesStavracas added this pull request to the merge queue Jan 7, 2025
Merged via the queue into flatpak:main with commit cb16d56 Jan 7, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build system Issues with the build system
Projects
Status: Triaged
Development

Successfully merging this pull request may close these issues.

Disable pytest and gets complained by missing python (Python is installed).
2 participants