settings: Do not export without implementations #1552
Merged
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Might make sense to always export the settings portal even if there are no backends. |
swick
reviewed
Jan 8, 2025
|
Having the settings portal exposed and returning nothing at all doesn't get us anything, so I'm now in favor of this change. This LGTM with the nit resolved. |
If no settings portal implementations are found, the `settings_create()` function currently returns NULL and the `No skeleton to export` warning. This change guards against that, which is more consistent with the other portals.
kleifgch
force-pushed
the
fix-filename-warning
branch
from
30f15c5 to
09edad5
Compare
swick
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If no settings portal implementations are found, the
settings_create()function currently returns NULL and theNo skeleton to exportwarning is emitted. This change guards against that, which is more consistent with the other portals.