Downgrade osquery-go due to panics in Shutdown and add more logging
#15017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharon-fdm
reviewed
Nov 7, 2023
mostlikelee
previously approved these changes
Nov 7, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #15017 +/- ##
==========================================
+ Coverage 59.00% 59.02% +0.02%
==========================================
Files 954 955 +1
Lines 80349 80471 +122
Branches 2222 2222
==========================================
+ Hits 47407 47501 +94
- Misses 29259 29281 +22
- Partials 3683 3689 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
mostlikelee
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#15022
The issue in the package is being fixed here osquery/osquery-go#117
But to not block on that we will downgrade the osquery-go version we use.
[ ] Changes file added for user-visible changes inchanges/ororbit/changes/.See Changes files for more information.
[ ] Documented any permissions changes (docs/Using Fleet/manage-access.md)[ ] Input data is properly validated,SELECT *is avoided, SQL injection is prevented (using placeholders for values in statements)[ ] Added support on fleet's osquery simulatorcmd/osquery-perffor new osquery data ingestion features.[ ] Added/updated testsFor Orbit and Fleet Desktop changes: