-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add host additional info filters #28
add host additional info filters #28
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding the SQLi fix!
I think the implementation is ready to merge. Before we do that can you please add a test in https://github.com/fleetdm/fleet/blob/master/server/datastore/datastore_hosts_test.go?
@@ -103,6 +104,33 @@ func (d *Datastore) ListHosts(opt kolide.HostListOptions) ([]*kolide.Host, error | |||
low, high := d.getLimitOffsetSliceBounds(opt.ListOptions, len(hosts)) | |||
hosts = hosts[low:high] | |||
|
|||
// Filter additional info |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the future please feel free not to implement anything in inmem. It's been mostly removed from use and I need to finish tearing it out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added tests, but did you also want me to remove this inmem implementation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need for that. I'll be removing all of this soon in any case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thank you for adding the test. I also tested manually in my local Fleet install and it worked as documented.
@@ -103,6 +104,33 @@ func (d *Datastore) ListHosts(opt kolide.HostListOptions) ([]*kolide.Host, error | |||
low, high := d.getLimitOffsetSliceBounds(opt.ListOptions, len(hosts)) | |||
hosts = hosts[low:high] | |||
|
|||
// Filter additional info |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need for that. I'll be removing all of this soon in any case.
This resolves kolide/fleet#2329. |
Use permissive file permissions to allow mounting files into Wix Docker container. Fixes #1424
This change adds the ability to filter additional host info via the list hosts endpoint; a continuation from here, but now filtering is accomplished via SQL.
Additional object without filter:
Additional object with filter: