Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix last chathead remove exception #35

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cazador4
Copy link

@cazador4 cazador4 commented Aug 4, 2017

No description provided.

@TheCrafter
Copy link

I just gave his PR a try and it seems to be working. He fixed the exception, that's for sure. I think you should accept it.

@icoolguy1995
Copy link

@TheCrafter I've tried this fix, but when removing the last chathead, key does seems to be removed. Can you check?

@TheCrafter
Copy link

@icoolguy1995 I do not understand what your problem is. Could you show me your code so I can understand better?

@icoolguy1995
Copy link

In a nutshell, removeView does not get called(for me) when removing last chathead.

@TheCrafter
Copy link

I don't know what to tell you.. I gets called for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants