Skip to content
This repository has been archived by the owner on Apr 14, 2024. It is now read-only.

move sidecar's envs into config.json #195

Merged

Conversation

cybwan
Copy link
Collaborator

@cybwan cybwan commented Oct 9, 2023

Description:

  1. move sidecar's ENVs into config.json
  2. add osm.sidecarDisabledMTLS

Testing done:
Done

Affected area:

Functional Area
New Functionality [ ]
CI System [ ]
CLI Tool [ ]
Certificate Management [ ]
Control Plane [ ]
Demo [ ]
Documentation [ ]
Egress [ ]
Ingress [ ]
Install [ ]
Networking [ ]
Observability [ ]
Performance [ ]
SMI Policy [ ]
Security [ ]
Sidecar Injection [ ]
Tests [ ]
Upgrade [ ]
Other [X]

Please answer the following questions with yes/no.

  1. Does this change contain code from or inspired by another project? no

  2. Is this a breaking change? no

  3. Has documentation corresponding to this change been updated in the osm-edge-docs repo (if applicable)? no

2. add osm.sidecarDisabledMTLS
@codecov-commenter
Copy link

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (675bc04) 60.86% compared to head (f6be1eb) 60.84%.
Report is 5 commits behind head on release-v1.3.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-v1.3     #195      +/-   ##
================================================
- Coverage         60.86%   60.84%   -0.02%     
================================================
  Files               218      218              
  Lines             17136    17138       +2     
================================================
- Hits              10430    10428       -2     
- Misses             6653     6657       +4     
  Partials             53       53              
Flag Coverage Δ
unittests 60.84% <11.11%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/messaging/broker.go 87.50% <100.00%> (+0.05%) ⬆️
pkg/configurator/methods.go 34.33% <0.00%> (-0.12%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reaver-flomesh reaver-flomesh merged commit 16e102f into flomesh-io:release-v1.3 Oct 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants