-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish app architecture 'case-study' pages #11414
Conversation
…-architecture-first
…-architecture-first
…-architecture-first
…-architecture-case-study
Visit the preview URL for this PR (updated for commit d46134f): https://flutter-docs-prod--pr11414-ew-app-architecture-case-st-5j24ywro.web.app |
General question, might not be the correct place. Are you also looking at adding this to the |
Yes, I'm going to update skeleton soon! That's next on my list for this project |
Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]> Co-authored-by: Parker Lougheed <[email protected]>
…lutter/website into ew-app-architecture-case-study
…-architecture-case-study
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making those initial adjustments @ericwindmill! And sorry about the delay on this second review.
I've gone through and left a few more comments as well as a few questions. Note that some might require modifications across the page or a few pages.
A few smaller comments were mostly about following the style guide, and in those cases I tried to link back to the relevant guidelines.
I don't have the entire context of the app architecture work, so please feel free to push back on anything that doesn't make sense or you'd prefer to complete in follow up work.
Thanks again :D
Co-authored-by: Parker Lougheed <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing all of my comments and questions @ericwindmill! I've made a few more minor changes and fixes, but in general this looks ready to land so you can keep iterating.
Great work on this gigantic section of documentation that will definitely help new developers understand and implement the recommendations :D
Once most of the architecture work has landed, I'll go through the architecture section again as a whole to complete any further cleanup and adjustments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hooray! Thanks for your review @parlough and thanks for your edits @miquelbeltran and @ericwindmill! I, too, want to review everything when it's in place. But for now, I land!
This is the second of two large PRs that add architecture guidance to the website.
The code snippets are from compass app in flutter/samples. It was been thoroughly reviewed.
Resolves third task from #11374
Fixes #11432
Presubmit checklist