Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show correct video for LinearGradient widget. #11420

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

antfitch
Copy link
Contributor

@antfitch antfitch commented Nov 20, 2024

Description of what this PR is changing or adding, and why:
The same video was appearing twice. This PR updates the one of the videos to display the correct one for the LinearGradient widget.

Issues fixed by this PR (if any):
11288

PRs or commits this PR depends on (if any):
n/a

Presubmit checklist

  • [ x] This PR is marked as draft with an explanation if not meant to land until a future stable release.
  • [ x] This PR doesn’t contain automatically generated corrections (Grammarly or similar).
  • [ x] This PR follows the Google Developer Documentation Style Guidelines — for example, it doesn’t use i.e. or e.g., and it avoids I and we (first person).
  • [ x] This PR uses semantic line breaks of 80 characters or fewer.

@antfitch antfitch requested review from sfshaza2, parlough and a team as code owners November 20, 2024 22:45
@sfshaza2
Copy link
Contributor

@antfitch, I should have told you this. When creating a PR, paste the bug that it fixes in the description box. Then when the PR lands, the bug is automatically closed.

@antfitch
Copy link
Contributor Author

@antfitch, I should have told you this. When creating a PR, paste the bug that it fixes in the description box. Then when the PR lands, the bug is automatically closed.

Done! Thank you for catching this.

@flutter-website-bot
Copy link
Collaborator

flutter-website-bot commented Nov 20, 2024

Visit the preview URL for this PR (updated for commit 3d4303a):

https://flutter-docs-prod--pr11420-website-11288-duplicate-vid-np8achxt.web.app

Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sfshaza2 sfshaza2 merged commit 5f26e5d into flutter:main Nov 20, 2024
9 checks passed
@parlough
Copy link
Member

parlough commented Nov 21, 2024

Just a note, to automatically close an issue when a PR is merged, you'll need to use one of the supported keywords and have the hash.

So in this case, something like this would work:

Fixes #11288

I personally prefer to just copy paste the whole link:

Fixes https://github.com/flutter/website/issues/11288

@antfitch
Copy link
Contributor Author

Just a note, to automatically close an issue when a PR is merged, you'll need to use of the supported keywords and have the hash.

So in this case, something like this would work:

Fixes #11288

I personally prefer to just use the whole link:

Fixes https://github.com/flutter/website/issues/11288

Thank you for letting me know about this. I'll make sure to do that moving forward.

@sfshaza2
Copy link
Contributor

sfshaza2 commented Nov 22, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants