-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show correct video for LinearGradient widget. #11420
Show correct video for LinearGradient widget. #11420
Conversation
@antfitch, I should have told you this. When creating a PR, paste the bug that it fixes in the description box. Then when the PR lands, the bug is automatically closed. |
Done! Thank you for catching this. |
Visit the preview URL for this PR (updated for commit 3d4303a): https://flutter-docs-prod--pr11420-website-11288-duplicate-vid-np8achxt.web.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Just a note, to automatically close an issue when a PR is merged, you'll need to use one of the supported keywords and have the hash. So in this case, something like this would work:
I personally prefer to just copy paste the whole link:
|
Thank you for letting me know about this. I'll make sure to do that moving forward. |
Yeah, I paste in the full link, too, but GitHub shortens it to just the
number with a link. Smart little GitHub. :)
…On Thu, Nov 21, 2024 at 9:31 AM Amanda Fitch ***@***.***> wrote:
Just a note, to automatically close an issue when a PR is merged, you'll
need to use of the supported keywords
<https://docs.github.com/en/issues/tracking-your-work-with-issues/using-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword>
and have the hash.
So in this case, something like this would work:
Fixes #11288
I personally prefer to just use the whole link:
Fixes #11288
Thank you for letting me know about this. I'll make sure to do that moving
forward.
—
Reply to this email directly, view it on GitHub
<#11420 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKS4PKKHAUWVOXQWZIOOVP32BYKFZAVCNFSM6AAAAABSFUXO4GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOJRHA2TKNZZGU>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
Description of what this PR is changing or adding, and why:
The same video was appearing twice. This PR updates the one of the videos to display the correct one for the LinearGradient widget.
Issues fixed by this PR (if any):
11288
PRs or commits this PR depends on (if any):
n/a
Presubmit checklist