Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adiak related testing and updates #172

Closed
wants to merge 28 commits into from
Closed

Adiak related testing and updates #172

wants to merge 28 commits into from

Conversation

tpatki
Copy link
Member

@tpatki tpatki commented Sep 25, 2024 •
edited
Loading

This branch builds on top of #167.
Goal is to test entry/exit hooks into main(), metadata in object format, and an adiak callback.

Adiak Related Edits:

tpatki added 28 commits September 18, 2024 23:00
@tpatki
Initial Structure for updating to the NewPassManager
419dd69
@tpatki
Add a basic module pass structure for perfflow_weave_new_pass. Untested.
83f20f6
@tpatki
Formatted.
fd0ed97
@tpatki
Add headers, comment one registration technique
9d1b1d8
@tpatki
Formatted.
d96754e
@tpatki
Add missing brace
2f8cd8f
@tpatki
Builds, but pass is not picked up with -XClang -load
6b09d5a
@tpatki
Try the EP Early Simplification Callback, similar to our legacy pass
5b3e7a0
@tpatki
Comment out the example code
ea779be
@tpatki
Add missing ;
430654b
@tpatki
Try adding the -fpass-plugin for clang 14+
51d4b59
@tpatki
Clean up, edit CMake to add -fpass-plugin for Clang14+, edit host-config
3d7a622
@tpatki
Update the CUDA compiler -Xcompiler flag.
e53ee4a
@tpatki
Formatted
ec2688a
@tpatki
Check if we can intercept main, so we know where to insert the Adiak …
3719b52 
…call
@tpatki
Builds correctly, can intercept main.
fc94860
@tpatki
First attempt at restructuring. Will probably not build. May split in…
6dfa001 
…to common.hpp/cpp as opposed to just the current hpp file.
@tpatki
Add relevant headers, only testing New pass
16c773c
@tpatki
Pick the right flag
cd038cb
@tpatki
NewPassMgr builds correctly. Buildlegacy pass now
9103cc1
@tpatki
Woohoo! We have a working NewPassManager that generates PFW files. Fo…
b9d1031 
…rmatting pass
@tpatki
Comment out some parts of legacy code
77b8033
@tpatki
Code Cleanup Pass 1. Rename some classes, variables, remove commented…
f426ddb 
… code.
@tpatki
Split perfflow_weave_common into hpp and cpp
5c583a0
@tpatki
Formatting pass
18a80b5
@tpatki
Remove Adiak testing and main function hooks from this PR
7e8154d
@tpatki
Formatting pass
ec15008
@tpatki
Create a new branch based on the NewPassManager to test Adiak related…
89fcfca 
… things
@tpatki tpatki mentioned this pull request Sep 25, 2024
Draft
21 tasks
@tpatki
Copy link
Member Author

tpatki commented Oct 11, 2024

Closing this PR after our decision around #175 and #176.
We will create a new version after we complete #175, based on Clang-15.

@tpatki tpatki closed this Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tpatki