view-job-records: add --bank filter option
#533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmoussa1
added
new feature
Problem: There is no way to filter jobs by bank when looking at job records in flux-accounting's "jobs" table. Add a "bank" column to the jobs table that will store an optional bank name for each job. Update the schema version of the DB with the addition of the column name. Add an option to filter jobs by "bank" when adding job records to the "jobs" table and while looking at job records with the view-job-records command.
Problem: A new column is added to the "jobs" table, but the test file that tests updating previous versions of flux-accounting DBs does not contain the schema version of the DB before this addition. Add the flux-accounting DB from v0.39.0 to the set of DBs tested in an update in t1017-update-db.t.
There is an expected output file for t1011-job-archive-interface.t that needs to be updated to account for the new "Bank" column in the output output of the view-job-records command. Update the expected output file to account for the addition of the new "Bank" column.
Problem: There are no tests that ensure filtering jobs by bank works. Add some basic tests.
cmoussa1
force-pushed
the
filter.jobs.by.bank
branch
from
7278f91 to
1c8ad78
Compare
jameshcorbett
approved these changes
Nov 12, 2024
|
Appreciate it! I'll set MWP here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There is no way to filter jobs by bank when looking at job records in flux-accounting's
jobstable. As mentioned in #530, there is a need to be able to easily look at jobs associated with their bank.This PR adds a
bankcolumn to thejobstable that can store an optional bank name for each job, fetched from the jobspec of each job. It is now included in the output offlux account view-job-records:It then adds an optional argument to the
view-job-recordscommand--bankwhich can filter jobs by bank name:flux account view-job-records --bank=bankAI've also added a new test file that tests filtering jobs by bank name.