Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rabbit state timings #278

Merged
merged 2 commits into from
Sep 11, 2024

Conversation

jameshcorbett
Copy link
Member

Could you check there are no obvious errors @bdevcich?

Problem: a sentence in the README doesn't make sense, it sets up
an "either... or" clause but then doesn't follow up with the "or"
part.

Fix the sentence.
Problem: there is no documentation of the `rabbit_STATE_timing`
attributes stored in each rabbit jobs' KVS, or of the
`rabbit_workflow` attribute.

Add documentation.
Copy link

@bdevcich bdevcich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@cmoussa1 cmoussa1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jameshcorbett jameshcorbett added the merge-when-passing mark PR for auto-merging by mergify.io bot label Sep 11, 2024
@mergify mergify bot merged commit 2ffde09 into flux-framework:master Sep 11, 2024
7 checks passed
@jameshcorbett jameshcorbett deleted the rabbit-state-timings branch September 11, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-when-passing mark PR for auto-merging by mergify.io bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants