-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Arm runners and bring back alpine #1328
Conversation
src/test/generate-matrix.py
Outdated
@@ -200,14 +204,14 @@ def __str__(self): | |||
) | |||
# Disabled because the arm64 build is failing and preventing the | |||
# generate-manifest step from running |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment should be removed as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, I'll clean that out. A couple other things that need to happen for this to work. The testenv container doesn't exist for arm, and the core container is in some kind of strange state, so we need to wait a bit anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment is still here?
fe30e42
to
bc8dde6
Compare
I think this is all set now. I'd like to re-enable the fedora40 arm setup, but we'd need to get that support back in core first. As a bit of a postmortem, the problems and solutions were as follows:
I'm working on a small PR to update a readme in core, but it might also be really good to port over the use of the arm runners, they're working really well as far as I can tell. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM just one little thing
src/test/generate-matrix.py
Outdated
@@ -200,14 +204,14 @@ def __str__(self): | |||
) | |||
# Disabled because the arm64 build is failing and preventing the | |||
# generate-manifest step from running |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment is still here?
Dang, I had that gone and must have brought it back in a rebase conflict. Thanks for the catch @jameshcorbett! |
003c3f6
to
e65a003
Compare
problem: the emulated arm64 environment is slow and causing problems solution: use the new native arm64 runners
problem: arm builds currently only run on master and do not run tests solution: run them always, and run the tests
problem: we disabled alpine, and it no longer needs to be solution: add alpine back in
Ok, I think this is all cleaned up. Setting MWP. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1328 +/- ##
======================================
Coverage 75.3% 75.3%
======================================
Files 111 111
Lines 16042 16042
======================================
Hits 12081 12081
Misses 3961 3961 |
This does a couple of things to enable new arm runners:
At least on a temporary basis this changes the matrix to always run the arm builds for testing purposes.