Skip to content

Commit

Permalink
imp: remove kill subcommand
Browse files Browse the repository at this point in the history
Problem: The `flux-imp kill` subcommand is no longer necessary,
since both IMP exec and run subcommands now have a privleged IMP
parent process via which signals may be forwarded.

Remove the `kill` subcommand and associated tests.
  • Loading branch information
grondo committed Nov 4, 2024
1 parent d1245cb commit 84d98a6
Show file tree
Hide file tree
Showing 5 changed files with 0 additions and 388 deletions.
1 change: 0 additions & 1 deletion src/imp/Makefile.am
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,6 @@ IMP_SOURCES = \
signals.h \
cgroup.c \
cgroup.h \
kill.c \
run.c \
exec/user.h \
exec/user.c \
Expand Down
5 changes: 0 additions & 5 deletions src/imp/impcmd-list.c
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,6 @@ extern int imp_casign_unprivileged (struct imp_state *imp, struct kv *);
extern int imp_casign_privileged (struct imp_state *imp, struct kv *);
extern int imp_exec_unprivileged (struct imp_state *imp, struct kv *);
extern int imp_exec_privileged (struct imp_state *imp, struct kv *);
extern int imp_kill_unprivileged (struct imp_state *imp, struct kv *);
extern int imp_kill_privileged (struct imp_state *imp, struct kv *);
extern int imp_run_unprivileged (struct imp_state *imp, struct kv *);
extern int imp_run_privileged (struct imp_state *imp, struct kv *);

Expand All @@ -41,9 +39,6 @@ struct impcmd impcmd_list[] = {
{ "exec",
imp_exec_unprivileged,
imp_exec_privileged },
{ "kill",
imp_kill_unprivileged,
imp_kill_privileged },
{ "run",
imp_run_unprivileged,
imp_run_privileged },
Expand Down
185 changes: 0 additions & 185 deletions src/imp/kill.c

This file was deleted.

1 change: 0 additions & 1 deletion t/Makefile.am
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ TESTSCRIPTS = \
t1002-sign-munge.t \
t1003-sign-curve.t \
t2000-imp-exec.t \
t2001-imp-kill.t \
t2002-imp-run.t \
t2003-imp-exec-pam.t

Expand Down
Loading

0 comments on commit 84d98a6

Please sign in to comment.