imp: exec: wait for job cgroup to be empty before exiting #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: The SA_RESTART flag is used when establishing signal handlers in the IMP, but this is not necessary (affected system calls like waitpid(2) already check for EINTR). It may also be convenient in future code to allow blocking system calls to be interrupted by signals to force the recheck of a condition, such as checking the contents of cgroup.procs. Drop the use of the SA_RESTART flag.
Problem: The IMP immediately exits after waitpid(2) returns for its immediate child, but this could leave extra processes running in the job's cgroup. Wait for the job cgroup to be empty before allowing the IMP to exit. An empty cgroup is considered one in which the only process is cgroup.procs is the IMP itself.
Problem: No test ensures that imp exec waits for the job cgroup to be empty before exiting. Add a test that sends SIGTERM to an IMP managing a process tree. This kills the immediate child of the IMP, and the IMP must wait until SIGUSR1 is sent, which terminates the cgroup with SIGKILL.
|
Thanks I'll set MWP |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies
imp execto wait for an "empty" cgroup before exiting, where empty meanscgroup.procscontains only the IMP's own PID.