Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add suggestion bundle support #3041

Closed
wants to merge 28 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
4298d66
add suggestion bundle support
granthamtaylor Jan 7, 2025
f1d291f
run pre-commit
granthamtaylor Jan 7, 2025
add0bac
update init
granthamtaylor Jan 7, 2025
9995829
simplify bundling setup. Now happens automatically via typing
granthamtaylor Jan 7, 2025
f481da6
remove Suggestion type
granthamtaylor Jan 7, 2025
356944d
allow for some suggestions to be defined as kwargs during bundling
granthamtaylor Jan 7, 2025
0554472
organize imports
granthamtaylor Jan 7, 2025
9fb2cb1
fix unit tests
granthamtaylor Jan 8, 2025
6acca75
remove positional only arg
granthamtaylor Jan 8, 2025
f57dc7a
replace and with or in tests (again)
granthamtaylor Jan 8, 2025
a912bfa
simplify to suggest over any dictionary
granthamtaylor Jan 8, 2025
b76e948
support recursive dictionaries
granthamtaylor Jan 8, 2025
0923a0d
update recursive method
granthamtaylor Jan 8, 2025
8b9af79
remove space
granthamtaylor Jan 8, 2025
8d80b9f
fix in-place process error
granthamtaylor Jan 8, 2025
d8a5bf4
simplify a tiny bit
granthamtaylor Jan 8, 2025
85712fe
add functionality for suggestion callback
granthamtaylor Jan 9, 2025
7364d25
fix test
granthamtaylor Jan 9, 2025
a488fa0
update typing to include Union operator
granthamtaylor Jan 9, 2025
65e87c7
fixed new unit test
granthamtaylor Jan 9, 2025
8bc3adb
remove ws
granthamtaylor Jan 9, 2025
5af7c60
clean up callback method
granthamtaylor Jan 10, 2025
749ac03
add typing-extensions based concat
granthamtaylor Jan 10, 2025
2e9190b
add optimize decorator
granthamtaylor Jan 11, 2025
cd31d51
run pre-commit
granthamtaylor Jan 11, 2025
8139800
add ParamSpec for typing
granthamtaylor Jan 11, 2025
fabd88e
fix import statements
granthamtaylor Jan 11, 2025
9589dfa
update docs
granthamtaylor Jan 11, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update typing to include Union operator
granthamtaylor committed Jan 9, 2025
commit a488fa03cea10f0c5025cf3e13def6b7b960c800
4 changes: 2 additions & 2 deletions plugins/flytekit-optuna/tests/test_optimizer.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from typing import Any
from typing import Any, Union

import asyncio
import math
@@ -76,7 +76,7 @@ def test_callback():


@fl.task
async def objective(letter: str, number: float|int, other: str, fixed: str) -> float:
async def objective(letter: str, number: Union[float, int], other: str, fixed: str) -> float:

loss = len(letter) + number + len(other) + len(fixed)