This repository has been archived by the owner on Jan 12, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2
MODCAT-211: Create a new API to delete an authority #454
Open
LeireDiez
wants to merge
10
commits into
master
Choose a base branch
from
UXPROD-2484
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eturienzo
approved these changes
Nov 16, 2020
@@ -10,7 +10,7 @@ | |||
"provides": [ | |||
{ | |||
"id": "marccat", | |||
"version": "2.1", | |||
"version": "2.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change the version
String url = getURI("/marccat/authority-record"); | ||
Map<String, String> headers = addDefaultHeaders(url, StorageTestSuite.TENANT_ID); | ||
String templateJson = IOUtils.toString(this.getClass().getResourceAsStream("/authority/name.json"), | ||
String.valueOf(StandardCharsets.UTF_8)); | ||
|
||
Response myResponse = | ||
given().headers("Content-Type", "application/json").headers(headers).queryParam("view", "-1") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reformat the code
Kudos, SonarCloud Quality Gate passed! 0 Bugs 80.6% Coverage The version of Java (1.8.0_275) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 11. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
MODCAT-211 Create a new API to delete an authority
Approach
TODOS and Open Questions
Learning
Pre-Merge Checklist
Before merging this PR, please go through the following list and take appropriate actions.
While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.