TCR-43 mod-marc-migrations #80
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * This criteria is failed in agreement with the submitted self evaluation.* | ||
| * [x] Data is segregated by tenant at the storage layer | ||
| * [ ] The module doesn't access data in DB schemas other than its own and public | ||
| * This module utilizes views (non materialized) to access data within mod-SRS and mod-inventory-storage. The evaluators feel that the use of views to access data in other schemas is a violation of this criteria. |
There was a problem hiding this comment.
"mod-SRS" is not one of the "previously accepted modules" required by the interfaces criterium above: https://folio-org.atlassian.net/wiki/spaces/REL/pages/5210256/FOLIO+Module+JIRA+project-Team-PO-Dev+Lead+responsibility+matrix
There was a problem hiding this comment.
mod-SRS (or mod-srs) doesn't exist in the folio-org GitHub organization:
https://github.com/folio-org/mod-SRS
https://github.com/folio-org/mod-srs
There was a problem hiding this comment.
I assume "mod-srs" refers to https://github.com/folio-org/mod-source-record-storage.
There was a problem hiding this comment.
In the evaluation form "mod-SRS" should be replaced with "mod-source-record-storage" if that is intended.
Added module title
Updated criteria evaluation.
Added explanation for criteria failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the completed evaluation of the mod-marc-migrations module.
See https://folio-org.atlassian.net/browse/TCR-43