Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[slider] Add option to disable touch-/mouse-sliding on the track #1987

Closed
wants to merge 4 commits into from
Closed

[slider] Add option to disable touch-/mouse-sliding on the track #1987

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b55306c
feat(slider): Allow disabling touch-/mouse-sliding on the track
mhthies Jun 17, 2021
fe02b89
fix(slider): Fix reference to slideEverywhere setting
mhthies Jun 17, 2021
b48c4f6
fix(slider): Fix touch event handling with \!slideEverywhere
mhthies Jun 19, 2021
d2df3c1
fix(slider): Fix broken eventPos function for mouse events
mhthies Jun 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 30 additions & 5 deletions src/definitions/modules/slider.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,12 +252,22 @@ $.fn.slider = function(parameters) {
},
mouseEvents: function() {
module.verbose('Binding mouse events');
$module.find('.track, .thumb, .inner').on('mousedown' + eventNamespace, function(event) {
var downElements = settings.slideEverywhere ? '.thumb,.inner,.track' : '.thumb';
$module.find(downElements).on('mousedown' + eventNamespace, function(event) {
event.stopImmediatePropagation();
event.preventDefault();
module.event.down(event);
});
$module.on('mousedown' + eventNamespace, module.event.down);
if(!settings.slideEverywhere) {
$module.find('.track, .inner').on('click' + eventNamespace, function(event) {
event.stopImmediatePropagation();
event.preventDefault();
module.event.up(event);
});
$module.on('click' + eventNamespace, module.event.up);
} else {
$module.on('mousedown' + eventNamespace, module.event.down);
}
$module.on('mouseenter' + eventNamespace, function(event) {
isHover = true;
});
Expand All @@ -267,12 +277,22 @@ $.fn.slider = function(parameters) {
},
touchEvents: function() {
module.verbose('Binding touch events');
$module.find('.track, .thumb, .inner').on('touchstart' + eventNamespace, function(event) {
var downElements = settings.slideEverywhere ? '.thumb,.inner,.track' : '.thumb';
$module.find(downElements).on('touchstart' + eventNamespace, function(event) {
event.stopImmediatePropagation();
event.preventDefault();
module.event.down(event);
});
$module.on('touchstart' + eventNamespace, module.event.down);
if(!settings.slideEverywhere) {
$module.find('.track, .inner').on('click' + eventNamespace, function(event) {
lubber-de marked this conversation as resolved.
Show resolved Hide resolved
event.stopImmediatePropagation();
event.preventDefault();
module.event.up(event);
});
$module.on('click' + eventNamespace, module.event.up);
} else {
$module.on('touchstart' + eventNamespace, module.event.down);
}
},
slidingEvents: function() {
// these don't need the identifier because we only ever want one of them to be registered with document
Expand Down Expand Up @@ -766,7 +786,11 @@ $.fn.slider = function(parameters) {
return value;
},
eventPos: function(event) {
if(module.is.touch()) {
// unwrap jQuery event objects
if(!(event.pageX || event.changedTouches)) {
event = event.originalEvent;
}
if(event.changedTouches) {
var
touchEvent = event.changedTouches ? event : event.originalEvent,
touches = touchEvent.changedTouches[0] ? touchEvent.changedTouches : touchEvent.touches,
Expand Down Expand Up @@ -1295,6 +1319,7 @@ $.fn.slider.settings = {
preventCrossover : true,
fireOnInit : false,
interpretLabel : false,
slideEverywhere : true, // If false, only allow clicking, not sliding on the track

//the decimal place to round to if step is undefined
decimalPlaces : 2,
Expand Down